Browse Source

todo cleanup

pull/2/head
Skycoder42 7 years ago
parent
commit
726321a73d
  1. 2
      src/imports/mvvmquick/PresentingDrawer.qml
  2. 1
      src/imports/mvvmquick/PresentingStackView.qml
  3. 2
      src/imports/mvvmquick/qqmlquickpresenter.cpp
  4. 10
      src/mvvmwidgets/widgetspresenter.cpp
  5. 1
      src/mvvmwidgets/widgetspresenter.h

2
src/imports/mvvmquick/PresentingDrawer.qml

@ -19,7 +19,7 @@ Drawer {
function presentDrawerContent(item) { function presentDrawerContent(item) {
if(_mainChild) if(_mainChild)
_mainChild.destroy(); _mainChild.destroy();
item.parent = _presentingDrawer.contentItem; //TODO test item.parent = _presentingDrawer.contentItem;
item.drawer = _presentingDrawer; item.drawer = _presentingDrawer;
_mainChild = item; _mainChild = item;
return true; return true;

1
src/imports/mvvmquick/PresentingStackView.qml

@ -72,7 +72,6 @@ StackView {
_clearItems = []; _clearItems = [];
} }
//TODO only for android? maybe move to second class?
pushEnter: Transition { pushEnter: Transition {
PropertyAnimation { PropertyAnimation {
property: "y" property: "y"

2
src/imports/mvvmquick/qqmlquickpresenter.cpp

@ -92,7 +92,7 @@ void QQmlQuickPresenter::present(ViewModel *viewModel, const QVariantHash &param
void QQmlQuickPresenter::showDialog(const MessageConfig &config, MessageResult *result) void QQmlQuickPresenter::showDialog(const MessageConfig &config, MessageResult *result)
{ {
if(!_qmlPresenter) { if(!_qmlPresenter) {
qmlWarning(this).space() << "No QML-Presenter registered! Unable to present dialog of type" //TODO use via define EVERYWHERE!!! qmlWarning(this).space() << "No QML-Presenter registered! Unable to present dialog of type"
<< config.type(); << config.type();
return; return;
} }

10
src/mvvmwidgets/widgetspresenter.cpp

@ -66,8 +66,6 @@ void WidgetsPresenter::present(ViewModel *viewModel, const QVariantHash &params,
// initialize viewmodel and view relationship // initialize viewmodel and view relationship
viewModel->setParent(view); viewModel->setParent(view);
auto hasCycle = setupLifeCycle(viewModel, view);
if(!hasCycle)
view->setAttribute(Qt::WA_DeleteOnClose); view->setAttribute(Qt::WA_DeleteOnClose);
viewModel->onInit(params); viewModel->onInit(params);
@ -187,14 +185,6 @@ bool WidgetsPresenter::tryPresent(QWidget *view, QWidget *parentView)
return true; return true;
} }
bool WidgetsPresenter::setupLifeCycle(ViewModel *viewModel, QWidget *view)
{
//TODO implement as soon as quick part is ready as well
Q_UNUSED(viewModel)
Q_UNUSED(view)
return false;
}
void WidgetsPresenter::showForeground(QWidget *view) const void WidgetsPresenter::showForeground(QWidget *view) const
{ {
if(view->windowState().testFlag(Qt::WindowMinimized)) if(view->windowState().testFlag(Qt::WindowMinimized))

1
src/mvvmwidgets/widgetspresenter.h

@ -51,7 +51,6 @@ Q_SIGNALS:
protected: protected:
virtual const QMetaObject *findWidgetMetaObject(const QMetaObject *viewModelMetaObject); virtual const QMetaObject *findWidgetMetaObject(const QMetaObject *viewModelMetaObject);
virtual bool tryPresent(QWidget *view, QWidget *parentView); virtual bool tryPresent(QWidget *view, QWidget *parentView);
virtual bool setupLifeCycle(ViewModel *viewModel, QWidget *view);
virtual void showForeground(QWidget *view) const; virtual void showForeground(QWidget *view) const;

Loading…
Cancel
Save